Skip to content

Commit

Permalink
koordlet: delete deprecated featuregate performance collector (#902)
Browse files Browse the repository at this point in the history
Signed-off-by: songtao98 <songtao2603060@gmail.com>
  • Loading branch information
songtao98 committed Dec 26, 2022
1 parent 26d27bf commit 403bc0f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions pkg/features/koordlet_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,6 @@ const (
// Accelerators enables GPU related feature in koordlet. Only Nvidia GPUs supported.
Accelerators featuregate.Feature = "Accelerators"

// owner: @songtao98 @zwzhang0107
// nolint:staticcheck // SA1019 this deprecated field still needs to be used for now.
// Deprecated: This feature gate will be removed in v1.1,
// please use CPICollector instead ASAP.
// PerformanceCollector enables cpi collector feature of koordlet.
PerformanceCollector featuregate.Feature = "PerformanceCollector"

// owner: @songtao98 @zwzhang0107
// alpha: v1.0
//
Expand Down Expand Up @@ -131,7 +124,6 @@ var (
CgroupReconcile: {Default: false, PreRelease: featuregate.Alpha},
NodeTopologyReport: {Default: true, PreRelease: featuregate.Beta},
Accelerators: {Default: false, PreRelease: featuregate.Alpha},
PerformanceCollector: {Default: false, PreRelease: featuregate.Alpha},
CPICollector: {Default: false, PreRelease: featuregate.Alpha},
PSICollector: {Default: false, PreRelease: featuregate.Alpha},
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/koordlet/metricsadvisor/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func (c *collector) Run(stopCh <-chan struct{}) error {
return
}
ic.collectContainerCPI()
}, []featuregate.Feature{features.PerformanceCollector, features.CPICollector}, c.config.CPICollectorIntervalSeconds, stopCh)
}, []featuregate.Feature{features.CPICollector}, c.config.CPICollectorIntervalSeconds, stopCh)

util.RunFeature(func() {
// psi collector support only on anolis os currently
Expand Down

0 comments on commit 403bc0f

Please sign in to comment.