Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] koord-descheduler: add a new arg evictAllBarePods to MigrationController #2099

Closed
songtao98 opened this issue Jun 12, 2024 · 1 comment · Fixed by #2102
Closed
Labels
kind/proposal Create a report to help us improve

Comments

@songtao98
Copy link
Contributor

What is your proposal:
Add a new arg evictAllBarePods to MigrationController to allow evicting pods without OwnerRef no matter it is in Failed phase.

Why is this needed:
Both Kubernetes Descheduler and koord-descheduler has a evictor arg evictFailedBarePods to allow evicting pods with no OwnerRef and in Failed phase. Although these pods won't be re-created by its upper controller, it is in Failed phase so that users can use this arg to allow plugins to evict these pods when knowing there's no risk.

In some special cases, users use some third-party components to make sure that they can re-create pods with no OwnerRef. Under this situation, pods without OwnerRef and are not in Failed phase should also be able to be evicted.

Users now can use the evict annotation to do this. But the annotation let the pod skip all filters. This is not acceptable because users just want to treat them normally. For example, they want to use objectLimiter to restrict the number of evicting pods without OwnerRef, too.

Is there a suggested solution, if so, please add it:

@ZiMengSheng
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Create a report to help us improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants