koord-descheduler: support evicting all bare pods in migration controller #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
+ Coverage 68.65% 68.66% +0.01%
==========================================
Files 430 430
Lines 40056 40071 +15
==========================================
+ Hits 27499 27515 +16
+ Misses 10192 10191 -1
Partials 2365 2365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
songtao98
force-pushed
the
support_evict_all_bare_pod
branch
2 times, most recently
from
4046bf3
to
1b91b40
Compare
Signed-off-by: songtao98 <songtao2603060@gmail.com>
songtao98
force-pushed
the
support_evict_all_bare_pod
branch
from
1b91b40
to
d45cf05
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR add a new arg
EvictAllBarePodsintoMigrationController. If this arg is set astrue, all bare pods including failed phase can be evicted. The default value isfalse. Users should know the risk and use this arg carefully because pods without OwnerRef cannot be re-created by default.To implement this, I mocked the
filterfunction in DefaultEvictor. Other functions used by MigrationController such asPreEvictionFilterare still be imported by the adapter.Ⅱ. Does this pull request fix one issue?
fixes #2099
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test