Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] cpu suppress policy should take fine-grined cpu orchestration into consideration #234

Closed
zwzhang0107 opened this issue Jun 8, 2022 · 3 comments · Fixed by #372
Closed

[proposal] cpu suppress policy should take fine-grined cpu orchestration into consideration #234

zwzhang0107 opened this issue Jun 8, 2022 · 3 comments · Fixed by #372
Assignees
@ZYecho
Labels
area/koordlet kind/proposal Create a report to help us improve
Milestone
v0.6

Comments

@zwzhang0107
Copy link
Contributor

What is your proposal:
cpu suppress policy change the cpuset of BE pod dynamically. fine-grined cpu orchestration rule should be considers. see #96 for more details.

Why is this needed:
BE pod should not share CPU with LSE.
fairness of the BE cpuset should be considered, in case the BE cpuset are shared to only few LSR/LS pods.

Is there a suggested solution, if so, please add it:
take the cpu core number into account during the share of cpuset between BE and LSR/LS.

  1. calculate the target number of suppressed cpu.
  2. each LSR/LS contribute some cpu to share with BE by their request proportion.
  3. apply cpuset for BE pods
@zwzhang0107 zwzhang0107 added the kind/proposal Create a report to help us improve label Jun 8, 2022
@zwzhang0107
Copy link
Contributor Author

/assign jasonliu747

@zwzhang0107 zwzhang0107 mentioned this issue Jun 8, 2022
Closed
7 tasks
@zwzhang0107
Copy link
Contributor Author

/area koordlet

@eahydra eahydra mentioned this issue Jun 8, 2022
Closed
23 tasks
@jasonliu747 jasonliu747 added this to the someday milestone Jun 9, 2022
@eahydra eahydra modified the milestones: someday, v0.5 Jun 21, 2022
@jasonliu747 jasonliu747 modified the milestones: v0.5, v0.6 Jun 28, 2022
@ZYecho ZYecho mentioned this issue Jul 15, 2022
Merged
3 tasks
@eahydra
Copy link
Member

eahydra commented Jul 15, 2022

/assign @ZYecho

ZYecho added a commit to ZYecho/koordinator that referenced this issue Jul 19, 2022
@ZYecho
fix: consider lse/lsr when cpu suppress (koordinator-sh#234)
1ebe298 
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
koordinator-bot bot pushed a commit that referenced this issue Jul 19, 2022
@ZYecho
fix: consider lse/lsr when cpu suppress (#234) (#372)
0523d60 
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this issue Jul 26, 2022
@ZYecho @jasonliu747
fix: consider lse/lsr when cpu suppress (koordinator-sh#234) (koordin…
2a113dd 
…ator-sh#372)

Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZYecho ZYecho

Labels
area/koordlet kind/proposal Create a report to help us improve
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

fix: consider lse/lsr when cpu suppress (#234) ZYecho/koordinator
4 participants
@eahydra @ZYecho @jasonliu747 @zwzhang0107