Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: compatible with lightweight-coscheduling #1007

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Feb 9, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Some users are still using lightweight-coscheduling, so require the coscheduling plugin to be compatible with lightweight-coscheduling. PodGroups are not created when the Pod uses the lightweight-coscheduling API.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra requested review from FillZpp, hormes, jasonliu747 and ZiMengSheng and removed request for FillZpp February 9, 2023 15:51
@eahydra
Copy link
Member Author

eahydra commented Feb 9, 2023

cc @tzzcfrank

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the compatible_with_lightweight-coscheduling branch from 12e4cc2 to 2e9f227 Compare February 9, 2023 16:03
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 67.52% // Head: 67.51% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2e9f227) compared to base (718bef7).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   67.52%   67.51%   -0.02%     
==========================================
  Files         249      249              
  Lines       28174    28177       +3     
==========================================
- Hits        19025    19024       -1     
- Misses       7844     7852       +8     
+ Partials     1305     1301       -4     
Flag Coverage Δ
unittests 67.51% <62.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scheduler/plugins/coscheduling/core/gang_cache.go 74.11% <57.14%> (-0.74%) ⬇️
pkg/scheduler/plugins/coscheduling/core/gang.go 76.97% <100.00%> (-1.27%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Feb 10, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 16be105 into koordinator-sh:main Feb 10, 2023
@eahydra eahydra added this to the v1.2 milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants