Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project presentation based on chatgpt's suggestion #1009

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

hormes
Copy link
Member

@hormes hormes commented Feb 10, 2023

Signed-off-by: Fansong Zeng fanster.z@gmail.com

Ⅰ. Describe what this PR does

With the aim of better describing the features and goals of the project, I have revised the project introduction. I have added descriptions of the advantages of Koordinator, such as improved resource utilization, enhanced performance, and flexible scheduling policies. I believe these changes will help more people understand the characteristics and benefits of Koordinator, thus attracting more users.

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 67.52% // Head: 67.50% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9c58348) compared to base (7adc5f6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   67.52%   67.50%   -0.02%     
==========================================
  Files         249      249              
  Lines       28177    28177              
==========================================
- Hits        19026    19022       -4     
  Misses       7850     7850              
- Partials     1301     1305       +4     
Flag Coverage Δ
unittests 67.50% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 65.88% <0.00%> (-1.18%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常fashion了

@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member Author

hormes commented Feb 13, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e66434a into koordinator-sh:main Feb 13, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants