Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name to slo-controller-config cfg->NodeStrategies as selector alias #1020

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

chzhj
Copy link
Member

@chzhj chzhj commented Feb 16, 2023

Ⅰ. Describe what this PR does

add name to slo-controller-config cfg->NodeStrategies as selector alias
see details #1011

Ⅱ. Does this pull request fix one issue?

fixes #1011

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 67.47% // Head: 67.45% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (79c5971) compared to base (9703ae0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   67.47%   67.45%   -0.02%     
==========================================
  Files         251      251              
  Lines       28435    28435              
==========================================
- Hits        19186    19182       -4     
- Misses       7924     7929       +5     
+ Partials     1325     1324       -1     
Flag Coverage Δ
unittests 67.45% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-4.12%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: chzhj <blueheartcheng@gmail.com>
@saintube
Copy link
Member

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7a04d5f into koordinator-sh:main Feb 20, 2023
@chzhj chzhj mentioned this pull request Feb 21, 2023
7 tasks
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] add name to slo-controller-config cfg->NodeStrategies as selector alias
4 participants