Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: use libcontainer check cgroupfsv2 #1021

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

huiwq1990
Copy link
Contributor

Ⅰ. Describe what this PR does

Use libcontainer check if the os support cgroupfsv2, and the default value for system.UseCgroupsV2 maybe change to
true.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • [] I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huiwq1990 huiwq1990 force-pushed the feat-cgroupcheck branch 2 times, most recently from 586d468 to 5d31850 Compare February 21, 2023 14:00
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 67.54% // Head: 67.56% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1d32cca) compared to base (f46ebb9).
Patch coverage: 56.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   67.54%   67.56%   +0.01%     
==========================================
  Files         252      252              
  Lines       28413    28445      +32     
==========================================
+ Hits        19191    19218      +27     
- Misses       7893     7899       +6     
+ Partials     1329     1328       -1     
Flag Coverage Δ
unittests 67.56% <56.86%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/system/cgroup2.go 1.01% <ø> (-4.55%) ⬇️
pkg/koordlet/util/system/util_test_tool.go 58.90% <40.90%> (-1.58%) ⬇️
pkg/koordlet/util/system/cgroup_driver_linux.go 23.45% <52.94%> (+7.83%) ⬆️
pkg/koordlet/util/system/cgroup_resource.go 81.81% <91.66%> (+1.29%) ⬆️
pkg/koordlet/resourceexecutor/updater.go 42.62% <0.00%> (+1.19%) ⬆️
pkg/koordlet/util/system/config.go 68.08% <0.00%> (+8.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Feb 22, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes
Copy link
Member

hormes commented Feb 22, 2023

Because the refactoring of metricadvisor caused merge conflicts, rebase was required

Makefile Show resolved Hide resolved
Signed-off-by: huiwq1990 <huiwq1990@163.com>
@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Feb 28, 2023
@koordinator-bot koordinator-bot bot merged commit 60bef78 into koordinator-sh:main Feb 28, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants