-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apis: deprecated device resource names with prefix kuberenetes.io #1025
apis: deprecated device resource names with prefix kuberenetes.io #1025
Conversation
/hold for test |
Codecov ReportBase: 67.45% // Head: 67.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 67.45% 67.48% +0.02%
==========================================
Files 251 251
Lines 28435 28432 -3
==========================================
+ Hits 19182 19188 +6
+ Misses 7929 7920 -9
Partials 1324 1324
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
5189476
to
94bdd1e
Compare
/hold cancel |
1f64893
to
a9d558c
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
a9d558c
to
597d6a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
The resource names starting with the prefix
kubernetes.io
in k8s are native resource types, and device plugins cannot use these resource names, otherwise the kubelet will reject them.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test