Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: deprecated device resource names with prefix kuberenetes.io #1025

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Feb 20, 2023

Ⅰ. Describe what this PR does

The resource names starting with the prefix kubernetes.io in k8s are native resource types, and device plugins cannot use these resource names, otherwise the kubelet will reject them.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Feb 20, 2023

/hold for test

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 67.45% // Head: 67.48% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (597d6a9) compared to base (7a04d5f).
Patch coverage: 98.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   67.45%   67.48%   +0.02%     
==========================================
  Files         251      251              
  Lines       28435    28432       -3     
==========================================
+ Hits        19182    19188       +6     
+ Misses       7929     7920       -9     
  Partials     1324     1324              
Flag Coverage Δ
unittests 67.48% <98.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/slo-controller/noderesource/noderesource.go 74.66% <93.75%> (-1.51%) ⬇️
pkg/koordlet/statesinformer/states_device_linux.go 37.94% <100.00%> (ø)
pkg/koordlet/statesinformer/states_nodemetric.go 61.65% <100.00%> (ø)
pkg/scheduler/plugins/deviceshare/device_cache.go 86.22% <100.00%> (+0.04%) ⬆️
pkg/scheduler/plugins/deviceshare/plugin.go 87.79% <100.00%> (+0.07%) ⬆️
pkg/scheduler/plugins/deviceshare/pod_handler.go 89.47% <100.00%> (+1.41%) ⬆️
pkg/scheduler/plugins/deviceshare/utils.go 100.00% <100.00%> (ø)
pkg/scheduler/plugins/coscheduling/core/gang.go 76.97% <0.00%> (-0.95%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra
Copy link
Member Author

eahydra commented Feb 21, 2023

/hold cancel
TBR

@eahydra eahydra added this to the v1.2 milestone Feb 21, 2023
@eahydra eahydra force-pushed the update_device_resource_names branch 2 times, most recently from 1f64893 to a9d558c Compare February 21, 2023 06:56
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Feb 22, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8773460 into koordinator-sh:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants