Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADOPTERS: add meiyapico as sample user #1045

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

kaori-seasons
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 67.48% // Head: 67.50% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d62997f) compared to base (ee5c420).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
+ Coverage   67.48%   67.50%   +0.02%     
==========================================
  Files         251      252       +1     
  Lines       28435    28397      -38     
==========================================
- Hits        19188    19169      -19     
+ Misses       7922     7896      -26     
- Partials     1325     1332       +7     
Flag Coverage Δ
unittests 67.50% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 61.76% <0.00%> (-5.30%) ⬇️
pkg/slo-controller/noderesource/noderesource.go 74.66% <0.00%> (-1.51%) ⬇️
...kg/descheduler/controllers/migration/controller.go 60.83% <0.00%> (-1.11%) ⬇️
pkg/koordlet/metricsadvisor/collector_gpu_linux.go
pkg/koordlet/metricsadvisor/be_collector.go
pkg/koordlet/metricsadvisor/collector.go
pkg/koordlet/metricsadvisor/config.go
pkg/koordlet/metricsadvisor/state.go
pkg/koordlet/metricsadvisor/collector_gpu.go
...dlet/metricsadvisor/performance_collector_linux.go
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

Welcome!

@zwzhang0107
Copy link
Contributor

/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using Koordinator!

ADOPTERS.md Outdated Show resolved Hide resolved
@hormes
Copy link
Member

hormes commented Feb 22, 2023

Welcome to the Koordinator community!

@FillZpp
Copy link
Member

FillZpp commented Feb 22, 2023

Welcome!

@hormes
Copy link
Member

hormes commented Feb 22, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 26755ea into koordinator-sh:main Feb 22, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants