Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: correct LabelGPUModel & LabelGPUDriverVersion #1058

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jasonliu747
Copy link
Member

@jasonliu747 jasonliu747 commented Feb 28, 2023

Ⅰ. Describe what this PR does

image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (60bef78) 67.56% compared to head (5e3fd85) 67.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   67.56%   67.59%   +0.03%     
==========================================
  Files         252      252              
  Lines       28445    28445              
==========================================
+ Hits        19219    19228       +9     
+ Misses       7895     7888       -7     
+ Partials     1331     1329       -2     
Flag Coverage Δ
unittests 67.59% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/coscheduling/core/gang.go 76.97% <0.00%> (-0.95%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+1.17%) ⬆️
...sor/collectors/beresource/be_resource_collector.go 73.91% <0.00%> (+6.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube
Copy link
Member

/lgtm

@eahydra
Copy link
Member

eahydra commented Feb 28, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 583c41c into main Mar 1, 2023
@jasonliu747 jasonliu747 deleted the jasonliu747-patch-1 branch April 6, 2023 09:46
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants