Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: improve the readability of the PreFilter error message of the DeviceShare plugin #1077

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

jasonliu747
Copy link
Member

Ⅰ. Describe what this PR does

Currently, the error message of PreFiltre in DeviceShare plugin cannot be understood intuitively.
This PR will improve the readability.

Ⅱ. Does this pull request fix one issue?

fix #840

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (150d96e) 67.23% compared to head (81c3640) 67.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   67.23%   67.22%   -0.02%     
==========================================
  Files         255      255              
  Lines       28622    28622              
==========================================
- Hits        19243    19240       -3     
- Misses       8038     8040       +2     
- Partials     1341     1342       +1     
Flag Coverage Δ
unittests 67.22% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/utils.go 100.00% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jasonliu747 jasonliu747 force-pushed the fix-840 branch 2 times, most recently from 10bd049 to ff52605 Compare March 6, 2023 12:29
@koordinator-bot koordinator-bot bot added size/M and removed size/S labels Mar 6, 2023
…ge of the DeviceShare plugin

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@eahydra
Copy link
Member

eahydra commented Mar 6, 2023

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 36a6221 into koordinator-sh:main Mar 7, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Improve the readability of the PreFilter error message of the DeviceShare plugin
4 participants