-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: require gc started for cacheable update #1078
koordlet: require gc started for cacheable update #1078
Conversation
2da1f8b
to
e785e9f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
==========================================
+ Coverage 67.23% 67.26% +0.03%
==========================================
Files 255 255
Lines 28622 28634 +12
==========================================
+ Hits 19243 19260 +17
+ Misses 8038 8036 -2
+ Partials 1341 1338 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e785e9f
to
a5fe93e
Compare
a5fe93e
to
6fe48de
Compare
Signed-off-by: saintube <saintube@foxmail.com>
6fe48de
to
0226bdd
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
To avoid memory leaks, require the cache GC to be started when the executor invokes cache updating.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test