Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: require gc started for cacheable update #1078

Conversation

saintube
Copy link
Member

@saintube saintube commented Mar 6, 2023

Ⅰ. Describe what this PR does

To avoid memory leaks, require the cache GC to be started when the executor invokes cache updating.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the koordlet-executor-update-require-gc branch from 2da1f8b to e785e9f Compare March 6, 2023 12:11
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.03 🎉

Comparison is base (150d96e) 67.23% compared to head (0226bdd) 67.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   67.23%   67.26%   +0.03%     
==========================================
  Files         255      255              
  Lines       28622    28634      +12     
==========================================
+ Hits        19243    19260      +17     
+ Misses       8038     8036       -2     
+ Partials     1341     1338       -3     
Flag Coverage Δ
unittests 67.26% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resourceexecutor/executor.go 42.95% <64.28%> (+10.10%) ⬆️
pkg/koordlet/resmanager/cgroup_reconcile.go 85.85% <100.00%> (ø)
pkg/koordlet/resmanager/system_config.go 59.64% <0.00%> (-10.53%) ⬇️
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (-0.27%) ⬇️
pkg/koordlet/resourceexecutor/updater.go 43.42% <0.00%> (+0.79%) ⬆️
pkg/scheduler/plugins/coscheduling/core/gang.go 77.91% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube saintube force-pushed the koordlet-executor-update-require-gc branch from e785e9f to a5fe93e Compare March 6, 2023 12:25
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Mar 6, 2023
@saintube saintube force-pushed the koordlet-executor-update-require-gc branch from a5fe93e to 6fe48de Compare March 6, 2023 12:39
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-executor-update-require-gc branch from 6fe48de to 0226bdd Compare March 6, 2023 13:06
@hormes
Copy link
Member

hormes commented Mar 7, 2023

/lgtm

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8a3428d into koordinator-sh:main Mar 8, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants