Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: pod eviction policy compatibility #1083

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

huiwq1990
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 10.52% and project coverage change: -0.08 ⚠️

Comparison is base (eb8afe4) 66.74% compared to head (4c1711e) 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   66.74%   66.66%   -0.08%     
==========================================
  Files         271      272       +1     
  Lines       29623    29669      +46     
==========================================
+ Hits        19771    19779       +8     
- Misses       8440     8479      +39     
+ Partials     1412     1411       -1     
Flag Coverage Δ
unittests 66.66% <10.52%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/pod_evict.go 0.00% <0.00%> (ø)
pkg/koordlet/resmanager/resmanager.go 58.06% <100.00%> (+3.02%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jasonliu747 jasonliu747 changed the title pod eviction policy compatibility koordlet: pod eviction policy compatibility Mar 7, 2023
pkg/util/pod_evict.go Outdated Show resolved Hide resolved
@huiwq1990 huiwq1990 force-pushed the feat-evicate branch 2 times, most recently from 9b567eb to 05d47eb Compare March 9, 2023 03:57
@huiwq1990 huiwq1990 force-pushed the feat-evicate branch 2 times, most recently from 461c87a to e0862ad Compare March 14, 2023 12:41
pkg/util/pod_evict.go Outdated Show resolved Hide resolved
@huiwq1990 huiwq1990 force-pushed the feat-evicate branch 2 times, most recently from f1b7cb5 to ef27ecd Compare March 22, 2023 15:44
Signed-off-by: huiwq1990 <huiwq1990@163.com>
@jasonliu747
Copy link
Member

related PR: #1151

@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Mar 29, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0623ffe into koordinator-sh:main Mar 29, 2023
2 checks passed
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants