Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: allow annotated migrationJob pass filter #1085

Merged

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Sometimes I create a PodMigrationJob to migrate one Pod but cannot pass the internal filters, but I known the risk about the migration.

K8s descheduler supports passing filters with Pod which has annotation descheduler.alpha.kubernetes.io/evict,
and koord-descheduler also supports this annotation but unsupports the job. So we should support it.

Ⅱ. Does this pull request fix one issue?

fixes #1084

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (150d96e) 67.23% compared to head (135352b) 67.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   67.23%   67.33%   +0.09%     
==========================================
  Files         255      258       +3     
  Lines       28622    28688      +66     
==========================================
+ Hits        19243    19316      +73     
+ Misses       8038     8020      -18     
- Partials     1341     1352      +11     
Flag Coverage Δ
unittests 67.33% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/descheduler/controllers/migration/controller.go 60.88% <100.00%> (+0.04%) ⬆️
pkg/descheduler/evictions/evictions.go 90.81% <100.00%> (ø)
pkg/scheduler/plugins/reservation/utils.go 77.35% <0.00%> (-1.22%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.80%) ⬇️
pkg/util/utils.go 55.73% <0.00%> (ø)
pkg/scheduler/plugins/deviceshare/utils.go 100.00% <0.00%> (ø)
...cheduler/plugins/reservation/garbage_collection.go 82.01% <0.00%> (ø)
pkg/scheduler/plugins/reservation/hook.go
pkg/util/reservation.go
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra added this to the v1.2 milestone Mar 7, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a40f96f into koordinator-sh:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] allow PodMigrationJob pass filter with annotation descheduler.alpha.kubernetes.io/evict
2 participants