-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: update PodRef after Reservation Bound during migration #1096
koord-descheduler: update PodRef after Reservation Bound during migration #1096
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 67.09% 67.07% -0.03%
==========================================
Files 262 262
Lines 28960 28978 +18
==========================================
+ Hits 19430 19436 +6
- Misses 8173 8181 +8
- Partials 1357 1361 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
8ea5346
to
50f0a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
this PR handle Reservation Bound Success and report boundPod to PodMigrationJob.Status.PodRef before check pod ready.
Ⅱ. Does this pull request fix one issue?
fixes #1093
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test