-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: revise node resource framework #1101
koord-manager: revise node resource framework #1101
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
=======================================
Coverage 66.65% 66.66%
=======================================
Files 266 268 +2
Lines 29210 29257 +47
=======================================
+ Hits 19470 19503 +33
- Misses 8355 8364 +9
- Partials 1385 1390 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pkg/slo-controller/noderesource/noderesource_controller_test.go
Outdated
Show resolved
Hide resolved
937bac7
to
608dfe8
Compare
pkg/slo-controller/noderesource/plugins/batchresource/plugin.go
Outdated
Show resolved
Hide resolved
608dfe8
to
65cf44b
Compare
Setting the priority on the plugin will make understanding very complicated, because the logic is scattered in different files, it is difficult to add a plugin to know where it should be placed. If there is a strong order dependency between plugins, then we should have a place to register each plugin uniformly and arrange their order here. |
I see that priority has been removed, and some comments and functions have not been removed |
65cf44b
to
5b71464
Compare
Fixed. |
5b71464
to
f091d63
Compare
f091d63
to
e02b3b2
Compare
e02b3b2
to
f47427f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
others PTAL @hormes @zwzhang0107
/lgtm |
Signed-off-by: saintube <saintube@foxmail.com>
f47427f
to
6c2e0e2
Compare
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Ⅰ. Describe what this PR does
Revise node resource framework:
Ⅱ. Does this pull request fix one issue?
fixes #1060
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test