Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: fix not compatible with ElasticQuota associated by namespace #1104

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Mar 10, 2023

Ⅰ. Describe what this PR does

When users create parent ElasticQuota in namespace and the pod in the namespace cannot be created.

As mentioned in the original design proposal , if the Pod does not specify a QuotaName, use the Namespace as the QuotaName to find the ElasticQuota, and if there is none, use the default ElasticQuota.

Ⅱ. Does this pull request fix one issue?

fix #1100

Ⅲ. Describe how to verify it

According to the reproduction method of issue #1100, the correct result expected by users can be achieved.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…espace

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v1.2 milestone Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 82.60% and project coverage change: +0.04 🎉

Comparison is base (7fafbe3) 66.98% compared to head (81d1877) 67.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   66.98%   67.02%   +0.04%     
==========================================
  Files         263      263              
  Lines       28975    28971       -4     
==========================================
+ Hits        19409    19419      +10     
+ Misses       8206     8196      -10     
+ Partials     1360     1356       -4     
Flag Coverage Δ
unittests 67.02% <82.60%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/scheduler/plugins/elasticquota/plugin_helper.go 84.92% <81.81%> (+0.79%) ⬆️
pkg/webhook/elasticquota/pod_check.go 91.17% <83.33%> (+4.33%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Mar 10, 2023

/lgtm

@hormes
Copy link
Member

hormes commented Mar 13, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6e5f7a1 into koordinator-sh:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] create parent ElasticQuota in koordinator-system and koordlet cannot created
2 participants