koord-scheduler: PodGroups are no longer created if pods use Gang annotations

[eahydra]

Ⅰ. Describe what this PR does

1. Remove the verification of the Gang name defined in the pod.
2. PodGroups are no longer created if pods use Gang annotations.

Ⅱ. Does this pull request fix one issue?

fix #1099

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (0ef6fd3) 67.00% compared to head (cf15f74) 67.05%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
+ Coverage   67.00%   67.05%   +0.04%     
==========================================
  Files         263      263              
  Lines       28975    28911      -64     
==========================================
- Hits        19416    19385      -31     
+ Misses       8199     8166      -33     
  Partials     1360     1360              

Flag	Coverage Δ
unittests	67.05% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/scheduler/plugins/coscheduling/core/gang.go	80.44% <ø> (+3.47%)	⬆️
.../scheduler/plugins/coscheduling/core/gang_cache.go	72.64% <100.00%> (-1.48%)	⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hormes]

After removing the gang cr, will the gang declared through the annotation have a memory object in the gangcache? Will it recover after process restart?

[eahydra]

After removing the gang cr, will the gang declared through the annotation have a memory object in the gangcache? Will it recover after process restart?

Yes, the Coscheduling plugin will create a Gang object in the GangCache if the Pod declares a Gang in the annotation. And recover from the Pod's annotations when the process starts.

[eahydra]

After removing the gang cr, will the gang declared through the annotation have a memory object in the gangcache? Will it recover after process restart?

When the Pod declares the Gang in the annotation, the reason why PodGroup is created is to give the user a chance to perceive the status of the Gang, but in fact, the user may not care about it at all.

[hormes]

/lgtm

[eahydra]

/approve

[koordinator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [eahydra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment