Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: Memcg reaper #1118

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

chzhj
Copy link
Member

@chzhj chzhj commented Mar 14, 2023

Ⅰ. Describe what this PR does

see details
memcg reaper support: #1032
add pod_name tag to pod evict metrics:#1117

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

2、add podName,podNamespace to cpu evict metric,
3、fix cpu evict log

Signed-off-by: chzhj <blueheartcheng@gmail.com>
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 94.91% and project coverage change: -0.25 ⚠️

Comparison is base (c77422b) 66.99% compared to head (e9d1986) 66.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   66.99%   66.74%   -0.25%     
==========================================
  Files         263      267       +4     
  Lines       28978    29319     +341     
==========================================
+ Hits        19413    19569     +156     
- Misses       8201     8363     +162     
- Partials     1364     1387      +23     
Flag Coverage Δ
unittests 66.74% <94.91%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/system/system_resource.go 65.62% <ø> (ø)
pkg/koordlet/resmanager/system_config.go 61.76% <66.66%> (+0.74%) ⬆️
pkg/koordlet/metrics/expire_metric.go 96.47% <96.47%> (ø)
pkg/koordlet/metrics/common.go 76.92% <100.00%> (+9.06%) ⬆️
pkg/koordlet/resmanager/cpu_evict.go 74.50% <100.00%> (ø)
pkg/koordlet/resmanager/resmanager.go 55.03% <100.00%> (ø)
pkg/koordlet/util/system/system_file.go 66.66% <100.00%> (+1.04%) ⬆️
pkg/koordlet/util/system/util_test_tool.go 50.29% <100.00%> (+0.29%) ⬆️
pkg/util/config.go 94.85% <100.00%> (+0.02%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title Memcg reaper koordlet: Memcg reaper Mar 16, 2023
Signed-off-by: chzhj <blueheartcheng@gmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@saintube
Copy link
Member

/lgtm
/assign @FillZpp @hormes

@FillZpp
Copy link
Member

FillZpp commented Mar 17, 2023

/approve

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 76fe941 into koordinator-sh:main Mar 17, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
@saintube saintube mentioned this pull request May 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal]add pod_name, pod_namespace tag to cpu evict metrics [proposal]support enable zombie Memcg reaper
6 participants