Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: cleanup cgroup path utils #1120

Merged

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

  1. Cleanup useless utility functions in the koordlet.
  2. Move out the functions for cgroup parent generating for extensions.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the koordlet-move-cgroupdir-util branch 2 times, most recently from 585a5e1 to fd51e44 Compare March 16, 2023 02:43
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-move-cgroupdir-util branch from fd51e44 to ca304ac Compare March 16, 2023 04:30
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 90.56% and project coverage change: +0.14 🎉

Comparison is base (0048950) 66.51% compared to head (ca304ac) 66.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   66.51%   66.65%   +0.14%     
==========================================
  Files         265      266       +1     
  Lines       29362    29210     -152     
==========================================
- Hits        19529    19470      -59     
+ Misses       8445     8353      -92     
+ Partials     1388     1387       -1     
Flag Coverage Δ
unittests 66.65% <90.56%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/stat.go 75.00% <ø> (+21.57%) ⬆️
pkg/koordlet/util/system/cgroup_resource.go 80.68% <ø> (ø)
pkg/koordlet/util/pod.go 33.33% <66.66%> (-26.67%) ⬇️
pkg/koordlet/util/container.go 69.49% <84.61%> (+8.48%) ⬆️
pkg/koordlet/util/cgroup_parent_utils.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b3bb7de into koordinator-sh:main Mar 16, 2023
@zwzhang0107 zwzhang0107 added this to the v1.2 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants