-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-proxy: add dockerfile for runtimeproxy #1123
runtime-proxy: add dockerfile for runtimeproxy #1123
Conversation
Signed-off-by: lucming <2876757716@qq.com>
a9a4bd1
to
2cb64ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FROM gcr.io/distroless/static:latest | ||
WORKDIR / | ||
COPY --from=builder /go/src/github.com/koordinator-sh/koordinator/koord-runtime-proxy . | ||
ENTRYPOINT ["/koord-runtime-proxy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an empty line at the end of this dockerfile
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 66.56% 66.55% -0.02%
==========================================
Files 265 265
Lines 29362 29362
==========================================
- Hits 19545 19542 -3
- Misses 8431 8433 +2
- Partials 1386 1387 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Ⅰ. Describe what this PR does
add dockerfile for runtime-proxy
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test