Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: fix repeated accumulation of node GPU resources #1149

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Mar 27, 2023

Ⅰ. Describe what this PR does

koord-manager: fix repeated accumulation of node GPU resources

Ⅱ. Does this pull request fix one issue?

fix #1147

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (b7d7a45) 66.77% compared to head (471c8b7) 66.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   66.77%   66.81%   +0.04%     
==========================================
  Files         271      271              
  Lines       29603    29606       +3     
==========================================
+ Hits        19766    19782      +16     
+ Misses       8425     8416       -9     
+ Partials     1412     1408       -4     
Flag Coverage Δ
unittests 66.81% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...troller/noderesource/device_resource_calculator.go 59.32% <100.00%> (+4.53%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 1eedb9b into koordinator-sh:main Mar 27, 2023
9 checks passed
@eahydra eahydra added this to the v1.2 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The koordinator gpu resource capacity recorded by the node is wrong
2 participants