Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: fix externally created MigrationJob not using default mode #1152

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Mar 28, 2023

Ⅰ. Describe what this PR does

The migrationController in koord-descheduler does not support external created MigrationJob using default mod if the job does not set the spec.Mode. This PR fixes the issue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…ult mode

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (1eedb9b) 66.80% compared to head (d0b414d) 66.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   66.80%   66.83%   +0.02%     
==========================================
  Files         271      271              
  Lines       29607    29608       +1     
==========================================
+ Hits        19779    19788       +9     
+ Misses       8419     8413       -6     
+ Partials     1409     1407       -2     
Flag Coverage Δ
unittests 66.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/descheduler/controllers/migration/controller.go 65.62% <100.00%> (+0.73%) ⬆️
pkg/descheduler/evictions/evictions.go 90.81% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Mar 30, 2023
@eahydra eahydra added this to the v1.2 milestone Mar 30, 2023
@hormes
Copy link
Member

hormes commented Mar 30, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8e81f93 into koordinator-sh:main Mar 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants