-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: replace int64 with time.Duration in metricsadvisor module #1153
koordlet: replace int64 with time.Duration in metricsadvisor module #1153
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 66.74% 66.71% -0.04%
==========================================
Files 273 273
Lines 29879 29884 +5
==========================================
- Hits 19943 19937 -6
- Misses 8513 8522 +9
- Partials 1423 1425 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
What is the background for this change? |
现在关于时间的单位并不一致,有些是int64,有些是time.Duration,之前讨论过会逐渐统一成 time.Duration,也留了一些TODO koordinator/pkg/koordlet/metricsadvisor/framework/config.go Lines 46 to 54 in b7df4dd
|
d91efa3
to
75ab7f5
Compare
75ab7f5
to
29b1f89
Compare
Signed-off-by: Jason Liu <jasonliu747@gmail.com>
29b1f89
to
483b8f0
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test