-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-proxy: Add mutex lock to resolve concurrent lru cache access is not safe #1158
Conversation
Signed-off-by: xigang <wangxigang2014@gmail.com>
/assign @honpey |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
+ Coverage 66.76% 66.80% +0.04%
==========================================
Files 273 273
Lines 29937 29937
==========================================
+ Hits 19987 19999 +12
+ Misses 8526 8515 -11
+ Partials 1424 1423 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/cc @hormes @FillZpp @eahydra @jasonliu747 Take a look. |
/LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add mutex lock to resolve concurrent access
lru cache
is not safe.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
https://github.com/golang/groupcache/blob/master/lru/lru.go#L23
Ⅳ. Special notes for reviews
/cc @eahydra @jasonliu747 @honpey
V. Checklist
make test