Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-proxy: Add mutex lock to resolve concurrent lru cache access is not safe #1158

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

xigang
Copy link
Contributor

@xigang xigang commented Mar 29, 2023

Ⅰ. Describe what this PR does

Add mutex lock to resolve concurrent access lru cache is not safe.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

https://github.com/golang/groupcache/blob/master/lru/lru.go#L23

Ⅳ. Special notes for reviews

/cc @eahydra @jasonliu747 @honpey

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: xigang <wangxigang2014@gmail.com>
@xigang
Copy link
Contributor Author

xigang commented Mar 29, 2023

/assign @honpey

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (0623ffe) 66.76% compared to head (3d2de20) 66.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
+ Coverage   66.76%   66.80%   +0.04%     
==========================================
  Files         273      273              
  Lines       29937    29937              
==========================================
+ Hits        19987    19999      +12     
+ Misses       8526     8515      -11     
+ Partials     1424     1423       -1     
Flag Coverage Δ
unittests 66.80% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xigang
Copy link
Contributor Author

xigang commented Mar 30, 2023

/cc @hormes @FillZpp @eahydra @jasonliu747 Take a look.

@eahydra eahydra requested review from honpey and ZYecho March 30, 2023 02:47
@ZYecho
Copy link
Contributor

ZYecho commented Mar 30, 2023

/LGTM

@koordinator-bot koordinator-bot bot added the lgtm label Mar 30, 2023
@eahydra eahydra changed the title Fix: Add mutex lock to resolve concurrent lru cache access is not safe runtime-proxy: Add mutex lock to resolve concurrent lru cache access is not safe Mar 30, 2023
@hormes
Copy link
Member

hormes commented Mar 30, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 10b518b into koordinator-sh:main Mar 30, 2023
9 checks passed
@eahydra eahydra added this to the v1.2 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants