Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: revise sysctl initialization of the group identity #1172

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented Apr 3, 2023

Ⅰ. Describe what this PR does

Fix the sysctl initialization of the cgroup identity since the /proc/sys/kernel/sched_group_identity_enabled may be not allowed to reset in some versions of the Anolis os.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (acfeb34) 66.56% compared to head (4efc3fa) 66.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   66.56%   66.56%           
=======================================
  Files         277      277           
  Lines       30057    30049    -8     
=======================================
- Hits        20007    20003    -4     
+ Misses       8618     8617    -1     
+ Partials     1432     1429    -3     
Flag Coverage Δ
unittests 66.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/koordlet/runtimehooks/hooks/groupidentity/bvt.go 91.07% <100.00%> (ø)
...et/runtimehooks/hooks/groupidentity/interceptor.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: saintube <saintube@foxmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 6806f8d into koordinator-sh:main Apr 3, 2023
9 checks passed
@eahydra eahydra added this to the v1.2 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants