Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: fix device cache potential concurrency issue #1182

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jasonliu747
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (10209f4) 65.77% compared to head (df209b7) 65.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   65.77%   65.78%           
=======================================
  Files         290      290           
  Lines       30484    30480    -4     
=======================================
  Hits        20052    20052           
+ Misses       8969     8965    -4     
  Partials     1463     1463           
Flag Coverage Δ
unittests 65.78% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/device_cache.go 86.88% <83.33%> (-0.04%) ⬇️
pkg/scheduler/plugins/deviceshare/plugin.go 67.22% <100.00%> (ø)
pkg/scheduler/plugins/deviceshare/pod_handler.go 87.80% <100.00%> (+4.27%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member Author

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 832ecd0 into koordinator-sh:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants