Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: Node Resource Reservation supports apply policy #1217

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Apr 13, 2023

Ⅰ. Describe what this PR does

Add applyPolicy to enhance compatibility of Node Resource Reservation with kubelet reservation mechanism.

Ⅱ. Does this pull request fix one issue?

fix #1216

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Apr 13, 2023

@lucming PTAL

@eahydra eahydra changed the title all: Node Resource Reservation supports apply policy apis: Node Resource Reservation supports apply policy Apr 13, 2023
@eahydra eahydra force-pushed the enhanced_node_resource_reservation branch from 58d63a2 to 9a2a95b Compare April 13, 2023 16:08
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 76.56% and project coverage change: -0.02 ⚠️

Comparison is base (0af2a00) 66.13% compared to head (03d985e) 66.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
- Coverage   66.13%   66.12%   -0.02%     
==========================================
  Files         304      304              
  Lines       31573    31590      +17     
==========================================
+ Hits        20882    20888       +6     
- Misses       9167     9174       +7     
- Partials     1524     1528       +4     
Flag Coverage Δ
unittests 66.12% <76.56%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/node.go 71.42% <66.66%> (-14.62%) ⬇️
...dlet/statesinformer/states_noderesourcetopology.go 66.45% <100.00%> (-0.08%) ⬇️
...xt/sharedlisterext/node_reservation_transformer.go 75.00% <100.00%> (-11.37%) ⬇️
pkg/scheduler/plugins/elasticquota/node_handler.go 68.65% <100.00%> (-2.58%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra force-pushed the enhanced_node_resource_reservation branch from 9a2a95b to 12f869b Compare April 14, 2023 04:11
@FillZpp
Copy link
Member

FillZpp commented Apr 17, 2023

/lgtm

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the enhanced_node_resource_reservation branch from 12f869b to 03d985e Compare April 17, 2023 14:19
@koordinator-bot koordinator-bot bot removed the lgtm label Apr 17, 2023
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes hormes added the lgtm label Apr 18, 2023
@koordinator-bot koordinator-bot bot merged commit 365edbe into koordinator-sh:main Apr 18, 2023
16 checks passed
@saintube
Copy link
Member

/area koord-scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] NodeResourceReservation supports different apply policies
5 participants