-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-proxy: extract annotations from labels for docker #1220
runtime-proxy: extract annotations from labels for docker #1220
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 66.10% 66.08% -0.02%
==========================================
Files 304 304
Lines 31602 31604 +2
==========================================
- Hits 20889 20887 -2
- Misses 9180 9183 +3
- Partials 1533 1534 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wanghaogang <wanghaogang@kuaishou.com>
c94cdc6
to
4cb7f26
Compare
Why do you need to do this, can you add some description to help everyone understand its purpose? |
In dockershim,annotations and labels are merged because docker supports only labels. |
I got it, thanks for contributing this pr. |
/LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
runtime-proxy: extract annotations from labels for docker
In dockershim,annotations and labels are merged because docker supports only labels.
We should extract annotations from labels for docker in failOver as we do in HandleCreateContainer of RuntimeManagerDockerServer.
Ⅱ. Does this pull request fix one issue?
None
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test