Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-proxy: extract annotations from labels for docker #1220

Merged
merged 2 commits into from
May 12, 2023

Conversation

Solomonwisdom
Copy link
Contributor

@Solomonwisdom Solomonwisdom commented Apr 14, 2023

Ⅰ. Describe what this PR does

runtime-proxy: extract annotations from labels for docker

In dockershim,annotations and labels are merged because docker supports only labels.
We should extract annotations from labels for docker in failOver as we do in HandleCreateContainer of RuntimeManagerDockerServer.

Ⅱ. Does this pull request fix one issue?

None

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (e48cc2d) 66.10% compared to head (d21f11f) 66.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   66.10%   66.08%   -0.02%     
==========================================
  Files         304      304              
  Lines       31602    31604       +2     
==========================================
- Hits        20889    20887       -2     
- Misses       9180     9183       +3     
- Partials     1533     1534       +1     
Flag Coverage Δ
unittests 66.08% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/runtimeproxy/server/docker/server.go 66.41% <100.00%> (+0.52%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: wanghaogang <wanghaogang@kuaishou.com>
@hormes
Copy link
Member

hormes commented Apr 25, 2023

Why do you need to do this, can you add some description to help everyone understand its purpose?

@Solomonwisdom
Copy link
Contributor Author

In dockershim,annotations and labels are merged because docker supports only labels.
We should extract annotations from labels for docker in failOver as we do in HandleCreateContainer of RuntimeManagerDockerServer.
You can look this

@hormes
Copy link
Member

hormes commented May 11, 2023

I got it, thanks for contributing this pr.

@hormes hormes added this to the v1.3 milestone May 11, 2023
@ZYecho
Copy link
Contributor

ZYecho commented May 11, 2023

/LGTM

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit c2b26cc into koordinator-sh:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants