Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support System QOS reserved cpus #1225

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Apr 17, 2023

Ⅰ. Describe what this PR does

Users can set annotation node.koordinator.sh/system-qos-resource in node to reserve some cpu cores for Pods configured with System QoS. koord-scheduler should exclude these reserved CPUs for LSE/LSR Pods when allocating CPU cores.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 43.75% and project coverage change: -0.03 ⚠️

Comparison is base (0af2a00) 66.13% compared to head (db028ab) 66.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   66.13%   66.11%   -0.03%     
==========================================
  Files         304      304              
  Lines       31573    31585      +12     
==========================================
+ Hits        20882    20883       +1     
- Misses       9167     9173       +6     
- Partials     1524     1529       +5     
Flag Coverage Δ
unittests 66.11% <43.75%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/nodenumaresource/topology_eventhandler.go 53.84% <43.75%> (-3.30%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 351716d into koordinator-sh:main Apr 18, 2023
16 checks passed
@saintube
Copy link
Member

/area koord-scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants