koord-manager: add args for common controllers

[saintube]

Ⅰ. Describe what this PR does

Add command options for the common controllers. We can enable/disable the known controllers via the arg --controllers.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests
• All checks passed in make test

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (63e3948) 65.41% compared to head (a5f0616) 65.43%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
+ Coverage   65.41%   65.43%   +0.01%     
==========================================
  Files         309      309              
  Lines       31756    31756              
==========================================
+ Hits        20773    20779       +6     
+ Misses       9465     9458       -7     
- Partials     1518     1519       +1     

Flag	Coverage Δ
unittests	65.43% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...slo-controller/nodemetric/nodemetric_controller.go	52.29% <0.00%> (ø)
...controller/noderesource/noderesource_controller.go	39.39% <0.00%> (ø)
pkg/slo-controller/nodeslo/nodeslo_controller.go	46.61% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jasonliu747]

/lgtm

[zwzhang0107]

/lgtm
/approve

[FillZpp]

Should this be in feature-gate or a command-line flag?

For example, kube-controller-manager has --feature-gates to enable those features in controllers and --controllers to indicate which controllers should be started.

[saintube]

Should this be in feature-gate or a command-line flag?

For example, kube-controller-manager has --feature-gates to enable those features in controllers and --controllers to indicate which controllers should be started.

I think both options are acceptable since these controllers have different maturities. The main reason I chose the feature gate is that the webhook plugins are maintained in this way.

[hormes]

--controllers to indicate which controllers should be started

I think this is more accurate. The feature gate is a function switch, and the controller is more like a program. Some behaviors inside the controller should be controlled by the feature gate.

[saintube]

--controllers to indicate which controllers should be started

I think this is more accurate. The feature gate is a function switch, and the controller is more like a program. Some behaviors inside the controller should be controlled by the feature gate.

@FillZpp @hormes Fixed. PTAL.
Now we use --controllers to control which controllers should be added to the manager.

[hormes]

/lgtm

[eahydra]

/lgtm

[saintube]

/assign @FillZpp

[koordinator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/OWNERS [hormes]
• pkg/slo-controller/OWNERS [hormes,jasonliu747,zwzhang0107]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment