Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: LowNodeLoad supports configuring resourceWeights #1240

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Apr 21, 2023

Ⅰ. Describe what this PR does

The LowNodeLoad plugin in koord-descheduler supports users to configure different resource weights when calculating the utilization score ranking of Nodes/Pods.

Ⅱ. Does this pull request fix one issue?

fix #1175

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v1.3 milestone Apr 21, 2023
@eahydra eahydra changed the title descheduler: LowNodeLoad supports configuring resourceWeights koord-descheduler: LowNodeLoad supports configuring resourceWeights Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.63 ⚠️

Comparison is base (c88a2d4) 66.10% compared to head (071d7b4) 65.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   66.10%   65.47%   -0.63%     
==========================================
  Files         303      308       +5     
  Lines       31593    31927     +334     
==========================================
+ Hits        20885    20905      +20     
- Misses       9179     9493     +314     
  Partials     1529     1529              
Flag Coverage Δ
unittests 65.47% <87.50%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/descheduler/apis/config/v1alpha2/defaults.go 13.52% <82.35%> (ø)
...duler/framework/plugins/loadaware/low_node_load.go 75.49% <100.00%> (ø)
...er/framework/plugins/loadaware/utilization_util.go 88.56% <100.00%> (ø)
pkg/descheduler/utils/sorter/pod.go 88.88% <100.00%> (ø)
pkg/descheduler/utils/sorter/scorer.go 60.71% <100.00%> (-6.94%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit cc28a7f into koordinator-sh:main Apr 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] descheduler plugin LowNodeLoad supports setting resource weights
3 participants