Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: skip daemonset usageThreshold check #1243

Merged

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

DaemonSet Pod should be scheduled even if the node's usage exceeds the thresholds

Ⅱ. Does this pull request fix one issue?

fixes #1229

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.54 ⚠️

Comparison is base (cc28a7f) 65.49% compared to head (95cab24) 64.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   65.49%   64.95%   -0.54%     
==========================================
  Files         308      312       +4     
  Lines       31927    32557     +630     
==========================================
+ Hits        20911    21148     +237     
- Misses       9484     9862     +378     
- Partials     1532     1547      +15     
Flag Coverage Δ
unittests 64.95% <100.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/loadaware/helper.go 68.64% <100.00%> (+1.67%) ⬆️
pkg/scheduler/plugins/loadaware/load_aware.go 74.15% <100.00%> (+0.33%) ⬆️

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra
Copy link
Member

eahydra commented Apr 25, 2023

add ut please.

@koordinator-bot koordinator-bot bot added size/M and removed size/S labels Apr 25, 2023
@ZiMengSheng ZiMengSheng changed the title koord-scheduler: daemonset skip usageThreshold check koord-scheduler: skip daemonset usageThreshold check Apr 25, 2023
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit fc10219 into koordinator-sh:main Apr 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] DaemonSet Pod should be scheduled even if the node's usage exceeds the thresholds
2 participants