-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: skip daemonset usageThreshold check #1243
koord-scheduler: skip daemonset usageThreshold check #1243
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
- Coverage 65.49% 64.95% -0.54%
==========================================
Files 308 312 +4
Lines 31927 32557 +630
==========================================
+ Hits 20911 21148 +237
- Misses 9484 9862 +378
- Partials 1532 1547 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
add ut please. |
4785456
to
ccc74b4
Compare
ccc74b4
to
c5673fa
Compare
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
c5673fa
to
95cab24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
DaemonSet Pod should be scheduled even if the node's usage exceeds the thresholds
Ⅱ. Does this pull request fix one issue?
fixes #1229
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test