Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support sandbox cpuset for rund #1248

Merged
merged 1 commit into from
Apr 26, 2023
Merged

koordlet: support sandbox cpuset for rund #1248

merged 1 commit into from
Apr 26, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Apr 25, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

pkg/koordlet/util/pod.go Outdated Show resolved Hide resolved
pkg/koordlet/runtimehooks/protocol/container_context.go Outdated Show resolved Hide resolved
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 37.06% and project coverage change: -0.59 ⚠️

Comparison is base (cc28a7f) 65.49% compared to head (14fbc5a) 64.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   65.49%   64.90%   -0.59%     
==========================================
  Files         308      312       +4     
  Lines       31927    32642     +715     
==========================================
+ Hits        20911    21187     +276     
- Misses       9484     9903     +419     
- Partials     1532     1552      +20     
Flag Coverage Δ
unittests 64.90% <37.06%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oordlet/runtimehooks/protocol/container_context.go 4.79% <0.00%> (-0.55%) ⬇️
pkg/koordlet/runtimehooks/protocol/protocol.go 3.27% <0.00%> (-0.30%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 55.49% <0.00%> (-10.59%) ⬇️
pkg/koordlet/util/cgroup_parent_utils.go 93.75% <ø> (-6.25%) ⬇️
pkg/koordlet/util/system/cgroup_driver.go 50.42% <0.00%> (-0.87%) ⬇️
pkg/koordlet/util/pod.go 71.42% <76.31%> (+16.88%) ⬆️
.../koordlet/runtimehooks/hooks/batchresource/rule.go 86.11% <100.00%> (ø)
pkg/koordlet/runtimehooks/hooks/cpuset/cpuset.go 87.75% <100.00%> (+0.38%) ⬆️
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 90.62% <100.00%> (+0.70%) ⬆️

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107 zwzhang0107 changed the title support sandbox cpuset for rund koordlet: support sandbox cpuset for rund Apr 26, 2023
@saintube
Copy link
Member

/lgtm

@zwzhang0107
Copy link
Contributor Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants