Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: generate mock states informer #1257

Merged
merged 1 commit into from Apr 27, 2023
Merged

koordlet: generate mock states informer #1257

merged 1 commit into from Apr 27, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented Apr 27, 2023

Ⅰ. Describe what this PR does

set pluginState, pluginOption, pluginName public for mock generation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 77.77% and no project coverage change.

Comparison is base (8ec0512) 64.91% compared to head (a8e6f78) 64.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   64.91%   64.92%           
=======================================
  Files         312      312           
  Lines       32660    32660           
=======================================
+ Hits        21201    21203    +2     
+ Misses       9908     9906    -2     
  Partials     1551     1551           
Flag Coverage Δ
unittests 64.92% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_pods.go 61.65% <0.00%> (ø)
pkg/koordlet/statesinformer/states_pvc.go 6.25% <0.00%> (ø)
pkg/koordlet/statesinformer/states_informer.go 66.66% <100.00%> (ø)
pkg/koordlet/statesinformer/states_node.go 58.41% <100.00%> (ø)
pkg/koordlet/statesinformer/states_nodemetric.go 61.65% <100.00%> (ø)
...dlet/statesinformer/states_noderesourcetopology.go 66.45% <100.00%> (ø)
pkg/koordlet/statesinformer/states_nodeslo.go 88.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4c32edd into koordinator-sh:main Apr 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants