Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add system usage in NodeMetric #1262

Merged
merged 1 commit into from
May 5, 2023
Merged

apis: add system usage in NodeMetric #1262

merged 1 commit into from
May 5, 2023

Conversation

zwzhang0107
Copy link
Contributor

@zwzhang0107 zwzhang0107 commented May 4, 2023

Ⅰ. Describe what this PR does

see #991

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (36c99b7) 64.91% compared to head (53281b6) 64.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   64.91%   64.90%   -0.02%     
==========================================
  Files         312      312              
  Lines       32660    32660              
==========================================
- Hits        21202    21198       -4     
- Misses       9905     9910       +5     
+ Partials     1553     1552       -1     
Flag Coverage Δ
unittests 64.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube
Copy link
Member

saintube commented May 5, 2023

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@FillZpp
Copy link
Member

FillZpp commented May 5, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4a493a8 into koordinator-sh:main May 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants