chore: more comments in injectForOrigin function #1264
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
+ Coverage 64.90% 65.07% +0.17%
==========================================
Files 312 312
Lines 32660 32661 +1
==========================================
+ Hits 21197 21254 +57
+ Misses 9910 9851 -59
- Partials 1553 1556 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@Tiana2018 The CI fails. Please check the DCO and sign-off the commit.
DCO
There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.
To avoid having PRs blocked in the future, always include Signed-off-by: Author Name authoremail@example.com in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
| @@ -190,7 +190,9 @@ func (c *ContainerContext) ReconcilerDone(executor resourceexecutor.ResourceUpda | |||
| c.injectForOrigin() | |||
| } | |||
|
|
|||
| // Inject illegal parameters | |||
There was a problem hiding this comment.
This comment should be removed. The parameters below are legal.
| "testing" | ||
|
|
||
| "github.com/koordinator-sh/koordinator/pkg/koordlet/resourceexecutor" |
There was a problem hiding this comment.
please move the private pkg at the last
| @@ -156,3 +176,85 @@ func TestPodResponse_ProxyDone(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
| func TestPodResponse_ReconcilerDone(t *testing.T) { | |||
There was a problem hiding this comment.
please left a blank line between functions
There was a problem hiding this comment.
Thank you for your suggestion.
Signed-off-by: tiana <917803833@qq.com>
|
/lgtm |
jasonliu747
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
add some comments in injectForOrigin Function
Ⅱ. Does this pull request fix one issue?
fixes #1251
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test