Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: fix variable typo #1286

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

stulzq
Copy link
Contributor

@stulzq stulzq commented May 10, 2023

Ⅰ. Describe what this PR does

fix variable typo

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.06 ⚠️

Comparison is base (a07b144) 64.78% compared to head (43d702e) 64.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
- Coverage   64.78%   64.73%   -0.06%     
==========================================
  Files         313      313              
  Lines       32947    32948       +1     
==========================================
- Hits        21346    21329      -17     
- Misses      10043    10055      +12     
- Partials     1558     1564       +6     
Flag Coverage Δ
unittests 64.73% <88.88%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/deviceshare/device_cache.go 87.06% <83.33%> (+0.03%) ⬆️
pkg/scheduler/plugins/deviceshare/plugin.go 67.22% <100.00%> (ø)
...o-controller/config/colocation_cm_event_handler.go 75.86% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonliu747
Copy link
Member

Please follow the instruction to sign-off your commit.
https://github.com/koordinator-sh/koordinator/pull/1286/checks?check_run_id=13370011329

Signed-off-by: Zhiqiang Li <stulzq@qq.com>
@stulzq
Copy link
Contributor Author

stulzq commented May 11, 2023

Please follow the instruction to sign-off your commit. https://github.com/koordinator-sh/koordinator/pull/1286/checks?check_run_id=13370011329

done

@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label May 11, 2023
@koordinator-bot koordinator-bot bot merged commit 810d3a3 into koordinator-sh:main May 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants