New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: coscheduling supports sensing PodGroup changes #1299
koord-scheduler: coscheduling supports sensing PodGroup changes #1299
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 64.78% 64.80% +0.02%
==========================================
Files 317 317
Lines 33127 33134 +7
==========================================
+ Hits 21461 21473 +12
+ Misses 10107 10096 -11
- Partials 1559 1565 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add more ut.
078e3b0
to
fc4eb48
Compare
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
fc4eb48
to
df97691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
PodGroup Spec may changed while scheduler is scheduling gang membe. Scheduler cache should be aware these changes and adjust its scheduling behavior
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test