Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: coscheduling supports sensing PodGroup changes #1299

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented May 18, 2023

Ⅰ. Describe what this PR does

PodGroup Spec may changed while scheduler is scheduling gang membe. Scheduler cache should be aware these changes and adjust its scheduling behavior

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 56.25% and project coverage change: +0.02 🎉

Comparison is base (52fd1b7) 64.78% compared to head (df97691) 64.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   64.78%   64.80%   +0.02%     
==========================================
  Files         317      317              
  Lines       33127    33134       +7     
==========================================
+ Hits        21461    21473      +12     
+ Misses      10107    10096      -11     
- Partials     1559     1565       +6     
Flag Coverage Δ
unittests 64.80% <56.25%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/coscheduling/core/gang.go 81.21% <ø> (+0.76%) ⬆️
.../scheduler/plugins/coscheduling/core/gang_cache.go 70.43% <53.33%> (-2.21%) ⬇️
pkg/scheduler/plugins/coscheduling/core/core.go 37.04% <100.00%> (+0.20%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add more ut.

pkg/scheduler/plugins/coscheduling/core/gang_cache.go Outdated Show resolved Hide resolved
@eahydra eahydra changed the title coscheduling: be aware of PodGroup changes koord-scheduler: coscheduling supports sensing PodGroup changes May 18, 2023
@koordinator-bot koordinator-bot bot added size/M and removed size/S labels May 18, 2023
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra
Copy link
Member

eahydra commented May 19, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 86ef836 into koordinator-sh:main May 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants