koord-scheduler: implement PreBindExtensions to support one-time apply patches #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahydra
requested review from
hormes,
FillZpp,
ZiMengSheng,
saintube and
jasonliu747
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
=======================================
Coverage 64.75% 64.75%
=======================================
Files 319 322 +3
Lines 33244 33306 +62
=======================================
+ Hits 21527 21568 +41
- Misses 10145 10174 +29
+ Partials 1572 1564 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eahydra
changed the title
eahydra
force-pushed
the
support_prebind_ext
branch
from
e8ad503
to
b43be46
Compare
|
/lgtm |
FillZpp
reviewed
May 23, 2023
| @@ -270,6 +283,8 @@ func (ext *frameworkExtenderImpl) RunPreBindPlugins(ctx context.Context, state * | |||
| reservation = reservation.DeepCopy() | |||
| reservation.Status.NodeName = nodeName | |||
|
|
|||
| original := reservation | |||
| reservation = reservation.DeepCopy() | |||
There was a problem hiding this comment.
Is there any way to avoid deepcopy the reservation twice?
…mmit patches Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
support_prebind_ext
branch
from
b43be46
to
d817eeb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy, FillZpp, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Optimize the Patch behavior of the koord-scheduler custom plugins:
DefaultPrebindplugin to initiate a Patch request. The plugin implements the new interfacePreBindExtensions.DefaultPreBindwill be added toKubeSchedulerConfigby default. The plugin can be disabled by setting theDisabledparameter, but after disabling, a new plugin implementation ofPreBindExtensionsneeds to be provided.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test