Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: ClusterColocationProfile support grayscale #1322

Merged

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented May 23, 2023

Ⅰ. Describe what this PR does

Add field Probability *intstr.IntOrString in ColocationProfile.Spec. The value range is 0-100. If it's 0, disable the profile; or if it's 100, all Pods can be modified; finnaly, generate a random value like rand.Intn(100), if the value is in 0-targetValue, modify the Pod.

Ⅱ. Does this pull request fix one issue?

fixes #1309

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 64.70% and project coverage change: -0.08 ⚠️

Comparison is base (b711f92) 64.80% compared to head (3e6bcad) 64.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   64.80%   64.72%   -0.08%     
==========================================
  Files         320      322       +2     
  Lines       33285    33526     +241     
==========================================
+ Hits        21569    21701     +132     
- Misses      10142    10253     +111     
+ Partials     1574     1572       -2     
Flag Coverage Δ
unittests 64.72% <64.70%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webhook/pod/mutating/cluster_colocation_profile.go 59.77% <64.70%> (+0.27%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZiMengSheng ZiMengSheng force-pushed the enhanced_colocation branch 2 times, most recently from 0ea04f1 to 8e0bf6c Compare May 23, 2023 12:41
@ZiMengSheng ZiMengSheng changed the title koord-manager: enhanced clusterColocationProfile koord-manager: ClusterColocationProfile support grayscale May 23, 2023
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit ab19627 into koordinator-sh:main May 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] ColocationProfile supports enhanced grayscale capabilities for matching Pods
3 participants