-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: ClusterColocationProfile support grayscale #1322
koord-manager: ClusterColocationProfile support grayscale #1322
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1322 +/- ##
==========================================
- Coverage 64.80% 64.72% -0.08%
==========================================
Files 320 322 +2
Lines 33285 33526 +241
==========================================
+ Hits 21569 21701 +132
- Misses 10142 10253 +111
+ Partials 1574 1572 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
0ea04f1
to
8e0bf6c
Compare
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
8e0bf6c
to
3e6bcad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add field Probability *intstr.IntOrString in ColocationProfile.Spec. The value range is 0-100. If it's 0, disable the profile; or if it's 100, all Pods can be modified; finnaly, generate a random value like rand.Intn(100), if the value is in 0-targetValue, modify the Pod.
Ⅱ. Does this pull request fix one issue?
fixes #1309
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test