Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support dispatching scheduling error #1324

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented May 23, 2023

Ⅰ. Describe what this PR does

koord-scheduler supports dispatching scheduling error that can give the chance to plugins to process scheduling errors.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the dispatch_scheduling_error branch from fe75669 to 5767abe Compare May 23, 2023 13:16
@eahydra eahydra requested review from stormgbs and ZYecho May 23, 2023 13:16
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 77.27% and project coverage change: -0.01 ⚠️

Comparison is base (4a53f32) 64.73% compared to head (5767abe) 64.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
- Coverage   64.73%   64.72%   -0.01%     
==========================================
  Files         322      323       +1     
  Lines       33306    33525     +219     
==========================================
+ Hits        21559    21700     +141     
- Misses      10179    10252      +73     
- Partials     1568     1573       +5     
Flag Coverage Δ
unittests 64.72% <77.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/frameworkext/interface.go 83.33% <ø> (ø)
...heduler/frameworkext/framework_extender_factory.go 76.25% <33.33%> (-1.68%) ⬇️
.../frameworkext/eventhandlers/reservation_handler.go 53.70% <50.00%> (+0.15%) ⬆️
.../scheduler/frameworkext/errorhandler_dispatcher.go 100.00% <100.00%> (ø)
pkg/scheduler/frameworkext/framework_extender.go 66.42% <100.00%> (+0.12%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented May 24, 2023

/lgtm

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@FillZpp
Copy link
Member

FillZpp commented May 24, 2023

/approve

1 similar comment
@eahydra
Copy link
Member Author

eahydra commented May 24, 2023

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, FillZpp, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e42cf8d into koordinator-sh:main May 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants