-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: allow skip update resource #1325
koord-manager: allow skip update resource #1325
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
- Coverage 64.69% 64.50% -0.20%
==========================================
Files 322 323 +1
Lines 33526 33721 +195
==========================================
+ Hits 21691 21753 +62
- Misses 10259 10390 +131
- Partials 1576 1578 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
79e010f
to
f298060
Compare
/lgtm |
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
f298060
to
affa316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
ClusterColocationProfile always modify the resources's request and limits if the Pod matched and is BE QoSClass, but should support skipping modify resources.
Ⅱ. Does this pull request fix one issue?
fixes #1308
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test