Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: allow skip update resource #1325

Merged
merged 1 commit into from
May 25, 2023

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

ClusterColocationProfile always modify the resources's request and limits if the Pod matched and is BE QoSClass, but should support skipping modify resources.

Ⅱ. Does this pull request fix one issue?

fixes #1308

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp May 24, 2023 02:27
@ZiMengSheng ZiMengSheng changed the title Resourceupdate koord-manager: allow annotated pod skip update resource May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.20 ⚠️

Comparison is base (ab19627) 64.69% compared to head (affa316) 64.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   64.69%   64.50%   -0.20%     
==========================================
  Files         322      323       +1     
  Lines       33526    33721     +195     
==========================================
+ Hits        21691    21753      +62     
- Misses      10259    10390     +131     
- Partials     1576     1578       +2     
Flag Coverage Δ
unittests 64.50% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...webhook/pod/mutating/cluster_colocation_profile.go 62.35% <100.00%> (+2.58%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZiMengSheng ZiMengSheng force-pushed the resourceupdate branch 2 times, most recently from 79e010f to f298060 Compare May 25, 2023 02:05
@ZiMengSheng ZiMengSheng changed the title koord-manager: allow annotated pod skip update resource koord-manager: allow skip update resource May 25, 2023
@hormes
Copy link
Member

hormes commented May 25, 2023

/lgtm

pkg/features/features.go Outdated Show resolved Hide resolved
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0d6b644 into koordinator-sh:main May 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] ColocationProfile support skipping modify resources
3 participants