Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koordlet: pod/container PSI/CPI metircs cache to tsdb #1336

Merged
merged 2 commits into from Jun 13, 2023
Merged

koordlet: pod/container PSI/CPI metircs cache to tsdb #1336

merged 2 commits into from Jun 13, 2023

Conversation

zshmmm
Copy link
Contributor

@zshmmm zshmmm commented May 29, 2023

Ⅰ. Describe what this PR does

  1. refactor: koordlet: pod/container PSI/CPI metircs cache to tsdb
  2. see [proposal] refactor metric cache module in koordlet with tsdb-type storage #1241 for full description.

Ⅱ. Does this pull request fix one issue?

fix #1329

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented May 29, 2023 •
edited

Codecov Report

Patch coverage: 36.91% and project coverage change: -0.01 ⚠️

Comparison is base (db67e64) 64.65% compared to head (c15db89) 64.64%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
- Coverage   64.65%   64.64%   -0.01%     
==========================================
  Files         325      329       +4     
  Lines       33678    33830     +152     
==========================================
+ Hits        21773    21871      +98     
- Misses      10318    10366      +48     
- Partials     1587     1593       +6
Flag Coverage Δ
unittests 64.64% <36.91%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metriccache/metric_cache.go 24.50% <ø> (-22.68%) ⬇️
pkg/util/utils.go 27.17% <0.00%> (-1.57%) ⬇️
pkg/koordlet/metriccache/metric_types.go 54.94% <6.66%> (-5.53%) ⬇️
...lectors/performance/performance_collector_linux.go 56.41% <41.86%> (-3.41%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

zwzhang0107
zwzhang0107 reviewed May 31, 2023
View reviewed changes
pkg/koordlet/metriccache/metric_cache.go Show resolved Hide resolved
pkg/koordlet/metriccache/metric_resources.go Show resolved Hide resolved
pkg/koordlet/metriccache/metric_types.go Outdated Show resolved Hide resolved
pkg/koordlet/metriccache/metric_types.go Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
@zshmmm
koordlet: pod/container PSI/CPI metircs cache to tsdb
7726ed6 
Signed-off-by: zhushaohua <zshmmm@163.com>
@zshmmm zshmmm force-pushed the refactor-pod-container-psi-cpi-metircs-collector branch from b186ec5 to 7726ed6 Compare June 6, 2023 06:19
@zshmmm zshmmm requested a review from zwzhang0107 June 6, 2023 06:21
@zshmmm zshmmm force-pushed the refactor-pod-container-psi-cpi-metircs-collector branch from becb52b to ffa44e1 Compare June 6, 2023 08:43
zwzhang0107
zwzhang0107 reviewed Jun 7, 2023
View reviewed changes
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metriccache/metric_types.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collectors/performance/performance_collector_linux.go Outdated Show resolved Hide resolved
@zshmmm zshmmm force-pushed the refactor-pod-container-psi-cpi-metircs-collector branch from ffa44e1 to 7b4b05c Compare June 8, 2023 09:44
@zshmmm zshmmm force-pushed the refactor-pod-container-psi-cpi-metircs-collector branch from 7b4b05c to c15db89 Compare June 8, 2023 10:37
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Jun 9, 2023
@zwzhang0107
Copy link
Contributor

/assign @FillZpp

FillZpp
FillZpp approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f833fd9 into koordinator-sh:main Jun 13, 2023
16 checks passed
LambdaHJ pushed a commit to LambdaHJ/koordinator that referenced this pull request Jun 13, 2023
@zshmmm @LambdaHJ
koordlet: pod/container PSI/CPI metircs cache to tsdb (koordinator-sh…
125e750 
…#1336)

Signed-off-by: zhushaohua <zshmmm@163.com>
Signed-off-by: 黄金 <huangjin_henan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwzhang0107 zwzhang0107 zwzhang0107 left review comments

@FillZpp FillZpp FillZpp approved these changes

@jasonliu747 jasonliu747 Awaiting requested review from jasonliu747

Assignees

@FillZpp FillZpp

@zwzhang0107 zwzhang0107

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[proposal]refactor pod/container PSI/CPI metircs cache to tsdb
3 participants
@zshmmm @zwzhang0107 @FillZpp