Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: revise cgroup update err when unsupported or path not exist #1339

Merged

Conversation

saintube
Copy link
Member

@saintube saintube commented May 31, 2023

Ⅰ. Describe what this PR does

  • Revise the error handling when the cgroup resource update fails because the cgroup is unsupported or the file does not exist.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 47.45% and project coverage change: +0.04 🎉

Comparison is base (ca52ffb) 64.49% compared to head (2391957) 64.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
+ Coverage   64.49%   64.53%   +0.04%     
==========================================
  Files         324      324              
  Lines       33687    33709      +22     
==========================================
+ Hits        21726    21755      +29     
+ Misses      10380    10364      -16     
- Partials     1581     1590       +9     
Flag Coverage Δ
unittests 64.53% <47.45%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resourceexecutor/cgroup.go 62.68% <ø> (+2.23%) ⬆️
pkg/koordlet/resourceexecutor/updater.go 41.09% <0.00%> (+3.99%) ⬆️
pkg/koordlet/util/system/system_resource.go 65.62% <ø> (ø)
pkg/koordlet/util/system/util_test_tool.go 51.42% <37.50%> (+0.83%) ⬆️
pkg/koordlet/resourceexecutor/executor.go 43.47% <55.00%> (+0.52%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: saintube <saintube@foxmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7808b33 into koordinator-sh:main May 31, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants