Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix cgroup driver detection on cgroups-v2, revise UTs #1353

Conversation

saintube
Copy link
Member

@saintube saintube commented Jun 5, 2023

Ⅰ. Describe what this PR does

  1. Fix the cgroup driver detection when the koordlet pod runs on cgroups-v2.
  2. Revise UTs of the metrics advisor where the TSDB might be failed to create because of the local path.

Ⅱ. Does this pull request fix one issue?

fixes #1346.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube saintube force-pushed the koordlet-fix-cgroup-driver-detection-on-v2 branch from a8afeac to 6596b63 Compare June 5, 2023 03:16
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the koordlet-fix-cgroup-driver-detection-on-v2 branch from 6596b63 to 9090d00 Compare June 5, 2023 03:52
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.05 🎉

Comparison is base (04a51f4) 64.59% compared to head (9090d00) 64.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   64.59%   64.65%   +0.05%     
==========================================
  Files         325      325              
  Lines       33674    33674              
==========================================
+ Hits        21752    21772      +20     
+ Misses      10330    10311      -19     
+ Partials     1592     1591       -1     
Flag Coverage Δ
unittests 64.65% <84.61%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/node.go 5.40% <0.00%> (-2.19%) ⬇️
pkg/koordlet/util/system/cgroup_driver.go 50.42% <ø> (ø)
pkg/koordlet/util/pod.go 71.42% <100.00%> (ø)
pkg/koordlet/util/system/cgroup.go 12.09% <100.00%> (+3.69%) ⬆️
pkg/koordlet/util/system/cgroup_driver_linux.go 22.50% <100.00%> (ø)
pkg/koordlet/util/system/config.go 68.75% <100.00%> (ø)
pkg/koordlet/util/system/version.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 8c90077 into koordinator-sh:main Jun 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

koordlet not support cgroup v2
2 participants