-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: strictly check whether ReservationInfo is available or terminating #1354
koord-scheduler: strictly check whether ReservationInfo is available or terminating #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ceef30c
to
24c9b01
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 64.65% 64.69% +0.04%
==========================================
Files 325 325
Lines 33678 33687 +9
==========================================
+ Hits 21773 21795 +22
+ Misses 10318 10298 -20
- Partials 1587 1594 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
e8ce3dd
to
e4e378f
Compare
e4e378f
to
4acbbfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
4acbbfb
to
62b7c95
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Users create reused Reservation with finalizer, when need to delete Reservation, users first mark Reservation deleting, and clean other resources, then finally remove the finalizer to release Reservation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test