Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a histogram util #1365

Merged
merged 1 commit into from Jun 8, 2023
Merged

Conversation

hormes
Copy link
Member

@hormes hormes commented Jun 7, 2023

Ref to #1361

This tool comes from kubernetes/autoscaler, thanks to the open source predecessors.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 72.60% and project coverage change: +0.07 🎉

Comparison is base (db67e64) 64.65% compared to head (820b566) 64.72%.

❗ Current head 820b566 differs from pull request most recent head b5895fd. Consider uploading reports for the commit b5895fd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   64.65%   64.72%   +0.07%     
==========================================
  Files         325      329       +4     
  Lines       33678    33970     +292     
==========================================
+ Hits        21773    21986     +213     
- Misses      10318    10378      +60     
- Partials     1587     1606      +19     
Flag Coverage Δ
unittests 64.72% <72.60%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/histogram/histogram_mock.go 0.00% <0.00%> (ø)
pkg/util/histogram/decaying_histogram.go 72.58% <72.58%> (ø)
pkg/util/histogram/histogram_options.go 78.84% <78.84%> (ø)
pkg/util/histogram/histogram.go 80.76% <80.76%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b8e22c7 into koordinator-sh:main Jun 8, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants