koord-scheduler: Add unschedulable field to Reservation #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @eahydra |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage 64.12% 64.12%
=======================================
Files 342 342
Lines 35201 35204 +3
=======================================
+ Hits 22571 22573 +2
+ Misses 10964 10962 -2
- Partials 1666 1669 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eahydra
changed the title
FillZpp
force-pushed
the
add-reservation-unschedulable
branch
from
3029759
to
11438ea
Compare
FillZpp
force-pushed
the
add-reservation-unschedulable
branch
from
11438ea
to
0b7c1bd
Compare
Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
FillZpp
force-pushed
the
add-reservation-unschedulable
branch
from
0b7c1bd
to
bfb557f
Compare
eahydra
requested review from
hormes,
ZiMengSheng,
jasonliu747 and
KunWuLuan
and removed request for
buptcozy
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Add unschedulable field to Reservation.
Ⅱ. Does this pull request fix one issue?
fixes #1377
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test